Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Disable bracketed paste by default #379

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Tests: Disable bracketed paste by default #379

merged 2 commits into from
Oct 23, 2022

Conversation

tony
Copy link
Contributor

@tony tony commented Oct 22, 2022

@tony
Copy link
Contributor Author

tony commented Oct 22, 2022

@kislyuk Are you open to something like this?

kislyuk
kislyuk approved these changes Oct 22, 2022
View reviewed changes
Copy link
Owner

@kislyuk kislyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks. When this problem first started, I was hoping pexpect would fix this issue on their end, but that doesn't seem to be happening. Your solution is the next best thing.

@tony
Copy link
Contributor Author

tony commented Oct 22, 2022

@kislyuk This should make the downstream people mentioning this in #337 happy

Is it worth doing a PyPI release after this and pinging them perhaps?

@kislyuk
Copy link
Owner

kislyuk commented Oct 22, 2022

I don't think this in itself warrants a release, but yes, I can roll one soon.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022 •
edited
Loading

Codecov Report

Base: 80.59% // Head: 80.59% // No change to project coverage 👍

Coverage data is based on head (8fbf4b3) compared to base (8fbf4b3).
Patch has no changes to coverable lines.

❗ Current head 8fbf4b3 differs from pull request most recent head 8d961da. Consider uploading reports for the commit 8d961da to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #379   +/-   ##
========================================
  Coverage    80.59%   80.59%           
========================================
  Files            6        6           
  Lines          737      737           
========================================
  Hits           594      594           
  Misses         143      143

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kislyuk kislyuk merged commit 95cd8bb into kislyuk:develop Oct 23, 2022
@tony tony deleted the mock-inputrc branch October 23, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kislyuk kislyuk kislyuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test setup failures with Bash 5.1: AssertionError: '\x1b[?2004l\r\x1b[?2004h' != ''
3 participants
@tony @kislyuk @codecov-commenter